[Webkit-unassigned] [Bug 93971] [V8] Refactor away IsolatedWorld

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93971


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #158389|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #4 from Adam Barth <abarth at webkit.org>  2012-08-14 13:35:42 PST ---
(From update of attachment 158389)
View in context: https://bugs.webkit.org/attachment.cgi?id=158389&action=review

> Source/WebCore/bindings/v8/DOMWrapperWorld.h:45
> +    static PassRefPtr<DOMWrapperWorld> create(int worldId = mainWorldId) { return adoptRef(new DOMWrapperWorld(worldId)); }

Can you make createMainWorld be a separate function?  It's a bit too tempting to call create() and duplicate the main world.

> Source/WebCore/bindings/v8/DOMWrapperWorld.h:49
> +        if (m_worldId != mainWorldId)
> +            isolatedWorldCount--;

I would just make this unconditional and have a domWrapperWorldCount.  There's always going to be a main world, so we know how to interpet the value.

> Source/WebCore/bindings/v8/DOMWrapperWorld.h:57
> +

Please remove this blank line.

> Source/WebCore/bindings/v8/DOMWrapperWorld.h:58
> +    DOMWrapperWorld(int worldId): m_worldId(worldId)

This should be split onto two lines with the : as the first character of the second line (indented four spaces).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.