[Webkit-unassigned] [Bug 93629] Reduce Font.h includes across project -- improves RenderObject.h compile time

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93629





--- Comment #39 from nbhargava at google.com  2012-08-14 12:42:58 PST ---
> I suggest we make a first patch that just removes the inlining. Then we can follow up with the patch that makes all the include changes to get the build time improvements.

Makes sense to me. Should I split this into two bug reports or just leave it here and make the patches more incremental?

> So what have we learned about the performance impact of removing all this inlining?

In terms of performance, the outputted results make it seem like there isn't really an impact. That being said, I'm not familiar with the expected outputs at all, so I'm hoping someone else can chime in here as to whether these are effective.


Thanks for the additional comments. I will make those changes promptly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.