[Webkit-unassigned] [Bug 73819] [Gtk] Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73819





--- Comment #13 from chris fleizach <cfleizach at apple.com>  2012-08-14 11:49:03 PST ---
(From update of attachment 158374)
View in context: https://bugs.webkit.org/attachment.cgi?id=158374&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:494
> +        !getAttribute(aria_pressedAttr).isEmpty();

need to fix style warning

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:495
> +}

I think isButton() already returns true if ariaRoleAttribute is button.

You should probably have a comment explaining why having a non-empty aria-pressed attribute means its a toggle button

> Source/WebCore/accessibility/AccessibilityRenderObject.h:74
> +    virtual bool isToggleButton() const;

this should probably be private

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.