[Webkit-unassigned] [Bug 83045] Improve line breaking performance for complex text

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 14 11:00:23 PDT 2012


--- Comment #18 from mitz at webkit.org  2012-08-14 11:00:52 PST ---
(From update of attachment 153968)
View in context: https://bugs.webkit.org/attachment.cgi?id=153968&action=review

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:2368
> +            if (textLayoutInfo.first != t) {
> +                textLayoutInfo.first = t;
> +                textLayoutInfo.second = f.createLayout(t, width.currentWidth(), collapseWhiteSpace);
> +            }
> +            TextLayout* textLayout = textLayoutInfo.second.get();

This is very similar to the treatment of lineBreakIteratorInfo further down, so I want to understand the two differences:
1) It’s not checking for a change to t->characters() (which, I believe, can occur with counters, see r107733
2) It’s outside the loop that iterates over positions in the text. I think this is actually fine, and the lineBreakIteratorInfo check can also be moved outside the loop, but I am not sure

If there’s no good reason for the textLayoutInfo treatment to differ from the lineBreakIteratorInfo treatment, then can they be united?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list