[Webkit-unassigned] [Bug 93278] [Qt] QtWebKit fails to build with OpenGL support on QNX

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93278





--- Comment #4 from Milian Wolff <milian.wolff at kdab.com>  2012-08-14 07:19:07 PST ---
(In reply to comment #3)
> (From update of attachment 157199 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=157199&action=review
> 
> Seems like a hacky way of doing this. We already disable 3D_GRAPHICS on windows, see code above in the same file.

Agreed, I'd like to adapt the patch, but:

> > Tools/qmake/mkspecs/features/features.prf:260
> > +    DEFINES -= ENABLE_WEBGL=1
> > +    DEFINES += ENABLE_WEBGL=0
> 
> Not needed. This will be disabled by default if 3D_GRAPHICS is disabled.

Apparently not so, see the following, which you hit when you run build-webkit without explicitly disabling webgl. Imo, if the platform does not work with webgl, it should be disabled by default. In my eyes it is very inconvenient to remember which flags to pass to build-webkit instead of handling that in i.e. features.prf automatically:

( test -f Makefile.WebCore.Target || /home/milian/projects/qt5/install-playbook/bin/qmake /home/milian/projects/qt5/qtwebkit/Source/WebCore/Target.pri INSTALL_LIBS=/home/milian/projects/qt5/build-playbook/../install-playbook/ CONFIG+=release CONFIG-=debug -o Makefile.WebCore.Target ) && /usr/bin/make -f Makefile.WebCore.Target 
make[2]: Entering directory `/home/milian/projects/qt5/build-playbook/qtwebkit/Release/Source/WebCore'
qcc -Vgcc_ntoarmv7le -lang-c++ -c -fstack-protector -fstack-protector-all -Wno-psabi -O2 -fvisibility=hidden -fvisibility-inlines-hidden -fPIC -D_REENTRANT -DQ_OS_BLACKBERRY -DENABLE_3D_RENDERING=1 -DENABLE_ACCELERATED_2D_CANVAS=0 -DENABLE_ANIMATION_API=0 -DENABLE_BATTERY_STATUS=0 -DENABLE_BLOB=1 -DENABLE_CHANNEL_MESSAGING=1 -DENABLE_CSP_NEXT=0 -DENABLE_CSS3_FLEXBOX=1 -DENABLE_CSS_BOX_DECORATION_BREAK=1 -DENABLE_CSS_EXCLUSIONS=1 -DENABLE_CSS_FILTERS=1 -DENABLE_CSS_GRID_LAYOUT=0 -DENABLE_CSS_HIERARCHIES=0 -DENABLE_CSS_IMAGE_ORIENTATION=0 -DENABLE_CSS_IMAGE_RESOLUTION=0 -DENABLE_CSS_REGIONS=1 -DENABLE_CSS_SHADERS=0 -DENABLE_CSS_VARIABLES=0 -DENABLE_DASHBOARD_SUPPORT=0 -DENABLE_DATAGRID=0 -DENABLE_DATALIST_ELEMENT=1 -DENABLE_DATA_TRANSFER_ITEMS=0 -DENABLE_DETAILS_ELEMENT=1 -DENABLE_DEVICE_ORIENTATION=0 -DENABLE_DIRECTORY_UPLOAD=0 -DENABLE_DOWNLOAD_ATTRIBUTE=0 -DENABLE_FAST_MOBILE_SCROLLING=1 -DENABLE_FILE_SYSTEM=0 -DENABLE_FILTERS=1 -DENABLE_FTPDIR=1 -DENABLE_FULLSCREEN_API=1 -DENABLE_G
-I/home/milian/projects/qt5/qtwebkit/Source/WebCore/rendering/style -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/rendering/svg -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/storage -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/svg -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/svg/animation -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/svg/graphics -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/svg/graphics/filters -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/svg/properties -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/testing -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/websockets -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/workers -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/xml -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/xml/parser -I/home/milian/projects/qt5/qtwebkit/Source/ThirdParty -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/bridge/jsc -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/bindi
In file included from /home/milian/projects/qt5/qtwebkit/Source/WebCore/bindings/js/JSCanvasRenderingContextCustom.cpp:34:
/home/milian/projects/qt5/qtwebkit/Source/WebCore/html/canvas/WebGLRenderingContext.h:30:27: error: DrawingBuffer.h: No such file or directory
cc: /home/milian/bbndk-2.0.1/host/linux/x86/usr/lib/gcc/arm-unknown-nto-qnx6.5.0eabi/4.4.2/cc1plus error 1
make[2]: *** [obj/release/bindings/js/JSCanvasRenderingContextCustom.o] Error 1
make[2]: Leaving directory `/home/milian/projects/qt5/build-playbook/qtwebkit/Release/Source/WebCore'
make[1]: *** [sub-Target-pri-make_first-ordered] Error 2
make[1]: Leaving directory `/home/milian/projects/qt5/build-playbook/qtwebkit/Release/Source/WebCore'
make: *** [sub-Source-WebCore-WebCore-pro-make_first-ordered] Error 2
makeobj[0]: Leaving directory `/home/milian/projects/qt5/build-playbook/qtwebkit/Release'

Also, looking at WTF/wtf/Platform.h, there is:

#if ENABLE(WEBGL) && !defined(WTF_USE_3D_GRAPHICS)
#define WTF_USE_3D_GRAPHICS 1
#endif

So it's actually vice-versa: If WEBGL is enabled, 3D_GRAPHICS is used automatically.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.