[Webkit-unassigned] [Bug 93957] Clear pattern to prevent timing problem between cancelVibration and vibrate

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93957





--- Comment #4 from Kihong Kwon <kihong.kwon at samsung.com>  2012-08-14 05:44:45 PST ---
(In reply to comment #3)
> (From update of attachment 158301 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=158301&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        There is a timing issue in the cancelVibration.
> > +        Since vibrate works based on timer, cancelVibration might be called
> > +        eariler than vibrate when cancelVibration is called just after vibrate call.
> > +        It can be prevented from clearing m_pattern in the cancelVibration.
> 
> Can't you write a layout test for this?

There is no return value in the Vibration API.
Therefore, if we add layout test, I think we have only way to use printf like legacy notification tests.(LayoutTests/fast/notifications/)
But IMHO it's not good to us.
I would like to get your opinion about this please. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.