[Webkit-unassigned] [Bug 93931] [EFL] Remove alloca usage.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93931





--- Comment #7 from Grzegorz Czajkowski <g.czajkowski at samsung.com>  2012-08-14 03:06:52 PST ---
(In reply to comment #6)
> Created an attachment (id=158269)
 --> (https://bugs.webkit.org/attachment.cgi?id=158269&action=review) [details]
> patch
> 
> How about this?

Thanks for the patch and newly introduced solution how to avoid problems with a little problematic Edje_Message_Float_Set struct.

In the origin code 'buffer' is created on stack, so we don't need to take of freeing memory and possibles memory leaks but compiler complains on 'message' pointer after reinterpret_cast that it is not initialized.

Your patch creates 'buffer' on heap and it's deleted when function returns (delete [] buffer).
Additionally you have to twice cast, char * -> void and then void* -> Edje_Message_Float_Set*. 

Is it really worth to resolve this compilation warning?
Kubo what do you think?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.