[Webkit-unassigned] [Bug 93597] Add DeviceProximityController to support Proximity Events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93597





--- Comment #21 from Kihong Kwon <kihong.kwon at samsung.com>  2012-08-13 23:16:13 PST ---
> > Source/WebCore/dom/Document.cpp:2214
> > +#if ENABLE(PROXIMITY_EVENTS)
> > +    if (DeviceProximityController* controller = DeviceProximityController::from(page()))
> > +        controller->suspendEventsForAllListeners(domWindow());
> >  #endif
> 
> We shouldn't need to do this.  Perhaps DeviceProximityController should be an ActiveDOMObject?  I was looking at this code the other day and had the same thought about DeviceMotionController and DeviceOrientationController.

IMHO, we couldn't make controller to ActiveDOMObject in current implementation structure, because the controller is shared by several DOMWindows in the page.
In addition, there is no document object when device controller is made.

I would like to get your opinion.
Thanks for advance.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.