[Webkit-unassigned] [Bug 93931] Remove WebCore build warning message.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 13 23:09:19 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=93931





--- Comment #2 from Raphael Kubo da Costa (rakuco) <rakuco at webkit.org>  2012-08-13 23:09:48 PST ---
(From update of attachment 158214)
View in context: https://bugs.webkit.org/attachment.cgi?id=158214&action=review

> Source/WebCore/platform/efl/ScrollbarEfl.cpp:174
> -    char buffer[sizeof(Edje_Message_Float_Set) + sizeof(double)];
> -    Edje_Message_Float_Set* message = reinterpret_cast<Edje_Message_Float_Set*>(buffer);
> +    Edje_Message_Float_Set* message = static_cast<Edje_Message_Float_Set*>(alloca(sizeof(Edje_Message_Float_Set) + sizeof(double)));

Whenever you change weird constructs like this, you must check the logs and use svn blame first -- there is a reason for not using alloca() here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list