[Webkit-unassigned] [Bug 93912] Implement UndoManager's V8 bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93912





--- Comment #5 from Kentaro Hara <haraken at chromium.org>  2012-08-13 21:48:04 PST ---
(From update of attachment 158199)
View in context: https://bugs.webkit.org/attachment.cgi?id=158199&action=review

> Source/WebCore/bindings/v8/DOMTransaction.cpp:74
> +    v8::Handle<v8::Object> wrapper = v8::Handle<v8::Object>::Cast(toV8(this));

wrapper.IsEmpty() check would be needed.

> Source/WebCore/bindings/v8/custom/V8UndoManagerCustom.cpp:42
> +        return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate());

Nit: Now V8Proxy:: is not needed. Please rebase with the latest WebKit trunk.

> Source/WebCore/bindings/v8/custom/V8UndoManagerCustom.cpp:47
> +        return V8Proxy::throwTypeError("The first argument is not of type DOMTransaction.", args.GetIsolate());

Nit: Ditto.

> Source/WebCore/bindings/v8/custom/V8UndoManagerCustom.cpp:59
> +        return V8Proxy::setDOMException(ec, args.GetIsolate());

Nit: Ditto.

> Source/WebCore/bindings/v8/custom/V8UndoManagerCustom.cpp:60
> +    return v8::Handle<v8::Value>();

v8Undefined()

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.