[Webkit-unassigned] [Bug 93525] webkitfullscreenchange not fired properly in iframe

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93525





--- Comment #13 from Jer Noble <jer.noble at apple.com>  2012-08-13 16:02:19 PST ---
(From update of attachment 158108)
View in context: https://bugs.webkit.org/attachment.cgi?id=158108&action=review

> Source/WebCore/ChangeLog:18
> +        * dom/Document.cpp:
> +

Please specify which functions were modified in the ChangeLog.

> Source/WebCore/dom/Document.cpp:-5019
> -        if (settings->thirdPartyStorageBlockingEnabled())
> -            securityOrigin()->blockThirdPartyStorage();

These seem unrelated.  Was this intentional?

> Source/WebCore/dom/Document.cpp:5512
> -    // 1. Let doc be the context object. (i.e. "this")
> +    // 1. Let doc be the context object. (i.e. "this") 

Unnecessary whitespace change.

> Source/WebCore/dom/Document.cpp:5742
>          // If the element was removed from our tree, also message the documentElement.
> -        if (!contains(node.get()))
> +        if (!contains(node.get()) && !node->isFrameOwnerElement())

Please update the comment to explain why the !node->isFrameOwnerElement() is necessary.

> Source/WebCore/dom/Document.cpp:5757
> -        if (!contains(node.get()))
> +        if (!contains(node.get()) && !node->isFrameOwnerElement())

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.