[Webkit-unassigned] [Bug 73819] [Gtk] Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73819





--- Comment #5 from Alejandro Piñeiro <apinheiro at igalia.com>  2012-08-13 11:53:19 PST ---
(In reply to comment #4)

> 
> > What about something like this?
> > 
> > return (isButton() || ariaRoleAttribute() == ButtonRole)
> >     && !getAttribute(aria_pressedAttr).isEmpty();
> 
> isButton just checks that roleValue==ButtonRole. So this is equivalent to the case. This seems like check the same twice.
> 
> About the aria check, is there any real possibility of a button not being an aria button? There are some extra types of button, but looking at the code, if the aria button role is not a "plain" ButtonRole, it is also the case for the button role. In fact determineAccessibilityRole already checks aria stuff to determine the role. IMHO, having coreObject->roleValue as ButtonRole but the aria role as something different should not happen. Taking that into account, is it still required to add that check there?

Sorry I have just realized that you are talking about the new method created at AccessibilityRenderObject. It is true that in this case it was already checked that the role is button, but if in the future someone wants to add that method, that method should be safe by his own. I will also add those checks.

Sorry for the noise.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.