[Webkit-unassigned] [Bug 73819] [Gtk] Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73819





--- Comment #1 from Alejandro Piñeiro <apinheiro at igalia.com>  2012-08-13 10:14:43 PST ---
Created an attachment (id=158032)
 --> (https://bugs.webkit.org/attachment.cgi?id=158032&action=review)
Fixes the bug

I added an extra rule on the mapping between WebCore role and ATK roles in order to know if a button is a toggle button. In order to do that I use the attribute aria-pressed:

http://www.w3.org/TR/wai-aria/states_and_properties#aria-pressed

Submitting the patch first. I will start the test, but I wanted to give first the patch so it could be reviewed.

PS: the example page has an error. After this patch, the example toggle button that it is initially un-pressed still exposes push-button. This is because initially it doesn't have that attribute set to false. But from the w3c documentation, I understand that that attribute should be there. In the same way, if you press that toggle button, and unpress it again, it properly expose the toggle button role, so the attribute (set to false) is there.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.