[Webkit-unassigned] [Bug 93710] [WK2] Add getter for capture attribute of input element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93710





--- Comment #3 from Christophe Dumez <christophe.dumez at intel.com>  2012-08-13 05:50:00 PST ---
(From update of attachment 157929)
View in context: https://bugs.webkit.org/attachment.cgi?id=157929&action=review

> Source/WebKit2/Shared/WebOpenPanelParameters.cpp:66
> +#if ENABLE(MEDIA_CAPTURE)

Why not include the whole function definition in the #ifdef ?

> Source/WebKit2/UIProcess/API/C/WKOpenPanelParameters.cpp:53
> +    return toCopiedAPI(toImpl(parametersRef)->capture());

Should we have a #if ENABLE(MEDIA_CAPTURE) and return 0 if undefined?

> Source/WebKit2/UIProcess/API/C/WKOpenPanelParameters.h:46
> +WK_EXPORT WKStringRef WKOpenPanelParametersCopyCapture(WKOpenPanelParametersRef parametes);

"parameters"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.