[Webkit-unassigned] [Bug 92155] A script to analyze class dependencies for webkit code and patches

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92155





--- Comment #2 from Dirk Pranke <dpranke at chromium.org>  2012-08-12 23:35:34 PST ---
I've started looking at this, but I'm guessing you haven't written much python before :).

I'll have a lot more feedback tomorrow. You can also run lint-webkitpy on this and it'll help you get closer to our coding style (which follows the PEP-8 conventions for python).

The script looks useful; unfortunately it depends on gyp to get the include paths, and so it's chromium-specific. I'm not sure if it's worth trying to do anything to make it more generic at this point, it's probably better to see if it's useful as-is before we spend too much effort trying to make it portable.

I would try to get it to the point where we can land it as just a script so others can try it out before we try to make it an ews bot or anything like that.

It would also be helpful to attach some sample output for some of the patches you've run it on so far so people can get a sense of what it can do.

Also, we generally don't land anything into webkit -- even utility scripts like this -- without some sort of tests for it. We have abstractions for things like the filesystem that should make this not too painful.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.