[Webkit-unassigned] [Bug 90505] Set the access qualifier of two methods to query frame specific info of BitmapImage to protected.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 12 03:48:12 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=90505


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #151186|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #11 from Eric Seidel <eric at webkit.org>  2012-08-12 03:48:40 PST ---
(From update of attachment 151186)
View in context: https://bugs.webkit.org/attachment.cgi?id=151186&action=review

>>> Source/WebCore/platform/graphics/cg/GraphicsContext3DCG.cpp:103
>>> +    bool hasAlpha = image->isBitmapImage() ? image->currentFrameHasAlpha() : true;
>> 
>> Why is this the right thing for gif and other multi-frame images?
> 
> Do we end up using the current frame anyway?

Ah, I've now read your ChangeLog, sorry.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list