[Webkit-unassigned] [Bug 93492] [Qt] Make it possible to build without QtTest/QtPrintSuport

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93492





--- Comment #6 from Simon Hausmann <hausmann at webkit.org>  2012-08-12 02:19:20 PST ---
(From update of attachment 157241)
View in context: https://bugs.webkit.org/attachment.cgi?id=157241&action=review

>>> Source/WebKit/qt/Api/qwebframe.cpp:1468
>>> +#if HAVE(QTPRINTSUPPORT)
>> 
>> I think here and in the other function it might be good to have an
>> 
>>     #else
>>     UNUSED_PARAM(printer)
>>     #endif
>> 
>> or the like, to avoid a compiler warning.
> 
> There is no warning since -Wno-unused-parameter is added to QMAKE_CXXFLAGS in default_post.prf.

Ok

>>> Tools/Tools.pro:12
>>> +    contains(DEFINES, HAVE_QTTESTLIB=1): SUBDIRS += DumpRenderTree/qt/DumpRenderTree.pro
>> 
>> I'd like some sort of warning here, like in default_pre, that we're disabling DRT due to missing testlib.
> 
> Only for DRT, or WTR and tests too ?

All three of them I'd say, or more generally - if done in default_pre.prf like suggested - visible early when WebKit.pro is parsed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.