[Webkit-unassigned] [Bug 92827] [EFL][WK2] Add ewk_security_origin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92827





--- Comment #3 from Christophe Dumez <christophe.dumez at intel.com>  2012-08-11 11:58:03 PST ---
(From update of attachment 157157)
View in context: https://bugs.webkit.org/attachment.cgi?id=157157&action=review

You are not adding the ewk_security_origin.cpp to CMake? Also you did not make the new public header installable.

> Source/WebKit2/ChangeLog:9
> +        This new API will allow to pass security origins of WebDatabase, AppCache and LocalStrogage.

LocalStorage

> Source/WebKit2/UIProcess/API/efl/ewk_security_origin.cpp:40
> +    origin->host = eina_stringshare_add(toImpl(securityOrigin)->host().utf8().data());

Please move these 3 lines to _Ewk_Security_Origin constructor.

> Source/WebKit2/UIProcess/API/efl/ewk_security_origin.cpp:47
> +void deleteSecurityOrigin(Ewk_Security_Origin* origin)

We usually call this ewe_security_origin_free(). Also, it appears to be missing from the private header.

> Source/WebKit2/UIProcess/API/efl/ewk_security_origin.cpp:49
> +    eina_stringshare_del(origin->host);

Please move this to _Ewk_Security_Origin destructor.

> Source/WebKit2/UIProcess/API/efl/ewk_security_origin.cpp:50
> +    eina_stringshare_del(origin->protocol);

Ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_security_origin.h:39
> +typedef struct _Ewk_Security_Origin Ewk_Security_Origin;

Missing doc.

> Source/WebKit2/UIProcess/API/efl/ewk_security_origin.h:44
> + * It returns a internal string which sould not be modified.

"should"

> Source/WebKit2/UIProcess/API/efl/ewk_security_origin.h:51
> +EAPI const char *ewk_security_origin_host_get(const Ewk_Security_Origin* o);

star on wrong side.

> Source/WebKit2/UIProcess/API/efl/ewk_security_origin.h:60
> +EAPI uint32_t ewk_security_origin_port_get(const Ewk_Security_Origin* o);

Star on wrong side.

> Source/WebKit2/UIProcess/API/efl/ewk_security_origin.h:72
> +EAPI const char *ewk_security_origin_protocol_get(const Ewk_Security_Origin* o);

Star on wrong side.

> Source/WebKit2/UIProcess/API/efl/ewk_security_origin_private.h:26
> +Ewk_Security_Origin* createSecurityOrigin(WKSecurityOriginRef securityOrigin);

did we change coding style? We usually use ewk_security_origin_new().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.