[Webkit-unassigned] [Bug 92471] ASSERTION FAILED: allocatedMaxLogicalWidth <= cellMaxLogicalWidth : int WebCore::AutoTableLayout::calcEffectiveLogicalWidth()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92471





--- Comment #10 from Arpita Bahuguna <arpitabahuguna at gmail.com>  2012-08-11 05:39:29 PST ---
(In reply to comment #8)
> (From update of attachment 156350 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=156350&action=review
> 
> The code change is fine, but this needs a test case.
> 
> > Source/WebCore/ChangeLog:11
> > +        Existing tests should cover the changes made in this patch hence not adding any new tests.
> 
> That's not true: the rounding is properly covered by the tests. However we had no test triggering the ASSERT so you need to add such a test.
> 
Have added a test for verifying the assert.

> > Source/WebCore/rendering/AutoTableLayout.cpp:364
> > +                maxLogicalWidth = max(maxLogicalWidth, static_cast<int>(max(spanMaxLogicalWidth, cellMaxLogicalWidth) * 100  / cellLogicalWidth.percent()));
> 
> Do we still need this static_cast<int>?
Yes, that is still required as the outer max() will give an error if not casted, since cellLogicalWidth.percent() is a float.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.