[Webkit-unassigned] [Bug 93673] NRWT: Add high resolution as a platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93673





--- Comment #8 from Terry Anderson <tdanderson at chromium.org>  2012-08-10 10:39:51 PST ---
(In reply to comment #3)
> See also bug 93647 (no patch)

Can you please clarify the relationship between the two bugs? AFAICT, I still need to fix bug 93647 to ensure that bug 90192 can land (i.e., to check the correctness of high dpi pixel tests in chromium for both the software and hardware paths).

--- Comment #9 from Beth Dakin <bdakin at apple.com>  2012-08-10 11:01:38 PST ---
(In reply to comment #8)
> (In reply to comment #3)
> > See also bug 93647 (no patch)
> 
> Can you please clarify the relationship between the two bugs? AFAICT, I still need to fix bug 93647 to ensure that bug 90192 can land (i.e., to check the correctness of high dpi pixel tests in chromium for both the software and hardware paths).


If my understanding is correct, bug 93647 is about making the tests in fast/hidpi work. Those tests use WTR/DRT to simulate HiDPI mode on ANY device, so the results are expected to always be in 2x whether they are run on a 1x device, a 2x device, or a magical 16x device! 

This bug is about running ALL of the tests on a retina mac, which is a 2x device. There are many tests in other directories that have results checked in that expect a 1x device, so they fail on a 2x machine. See these bugs to get an idea of the kind of tests that require a platform/retina or platform/2x directory:

https://bugs.webkit.org/show_bug.cgi?id=89709
https://bugs.webkit.org/show_bug.cgi?id=89711
https://bugs.webkit.org/show_bug.cgi?id=89713
https://bugs.webkit.org/show_bug.cgi?id=89715

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.