[Webkit-unassigned] [Bug 93606] [Qt] UpdateAtlas is wasting memory

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93606





--- Comment #15 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-08-10 05:43:15 PST ---
(From update of attachment 157705)
View in context: https://bugs.webkit.org/attachment.cgi?id=157705&action=review

> Source/WebKit2/WebProcess/WebPage/UpdateAtlas.cpp:53
> +    delete m_areaAllocator;
> +    m_areaAllocator = 0;

OwnPtr? it has a clear() ? no?

> Source/WebKit2/WebProcess/WebPage/UpdateAtlas.cpp:76
> +   IntRect intrect(IntPoint::zero(), size);
> +   if (flags() & ShareableBitmap::SupportsAlpha) {
>          graphicsContext->setCompositeOperation(CompositeCopy);
> -        graphicsContext->fillRect(rect, Color::transparent, ColorSpaceDeviceRGB);
> +        graphicsContext->fillRect(intrect, Color::transparent, ColorSpaceDeviceRGB);

wrong indentation,

Why not just fillRect(IntRect(IntPoint::zero(), size)), ...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.