[Webkit-unassigned] [Bug 93590] Add NonImmediateBitmapImage to mark it is safe to decode asynchronously.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 10 04:51:29 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=93590





--- Comment #6 from Huang Dongsung <luxtella at company100.net>  2012-08-10 04:51:56 PST ---
(In reply to comment #3)
> I think a better name would be NonImmediateBitmapImage. It is unclear from the name what RetainedModeBitmapImage does.

Ok, I changed.

> This can be a simple boolean instead of counter.

Absolutely!

> There's no need to have this because this method doesn't trigger image decoding.

Yes.

> It will be more clear to only have this line in this method and draw().

Now only NonImmediateBitmapImage::draw() and NonImmediateBitmapImage::nativeImageForCurrentFrame() have this line.

> Looks like there's no user of this function other than toRetainedModeBitmapImageIfPossible, I'd combine them.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list