[Webkit-unassigned] [Bug 93597] Add DeviceProximityController to support Proximity Events

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 10 04:42:56 PDT 2012


--- Comment #16 from Kentaro Hara <haraken at chromium.org>  2012-08-10 04:43:21 PST ---
(From update of attachment 157633)
View in context: https://bugs.webkit.org/attachment.cgi?id=157633&action=review

Almost looks OK to me, but I'm not familiar with the code. Could any reviewer look at this patch?

> Source/WebCore/Modules/proximity/DeviceProximityController.h:59
> +    Page* m_page;

Is it needed?

> LayoutTests/fast/dom/Proximity/add-listener-from-callback.html:6
> +<script src="script-tests/add-listener-from-callback.js"></script>

Nit: you can directly write JavaScript here.

> LayoutTests/fast/dom/Proximity/basic-operation.html:6
> +<script src="script-tests/basic-operation.js"></script>


> LayoutTests/fast/dom/Proximity/event-after-navigation.html:6
> +<script src="script-tests/event-after-navigation.js"></script>


> LayoutTests/fast/dom/Proximity/multiple-frames.html:6
> +<script src="script-tests/multiple-frames.js"></script>


Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list