[Webkit-unassigned] [Bug 93467] Change ImageSource to be asynchronous.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93467





--- Comment #11 from Huang Dongsung <luxtella at company100.net>  2012-08-10 02:12:40 PST ---
(In reply to comment #6)
Thanks for review

> I believe image layout tests will verify the correctness of this change, but it's best to list the tests here, e.g.

Ok. I add the paragraph in the changelog

Test: compositing/images/*
      fast/images/*
      fast/dom/HTMLImageElement/*
      http/tests/images/*
      css3/images/*

> > -    ASSERT(m_decodedSize == 0 || numFrames > 1);
> I think we don't need to change this line in this patch.

Ok.

> > +    ASSERT(m_observer);
> I don't think this is necessary since constructor always have this assigned. If this is 0 it will crash in the following line anyway.
> I don't think ASSERT is needed here.

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.