[Webkit-unassigned] [Bug 93590] Add RetainedModeBitmapImage to mark it is safe to decode asynchronously.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93590





--- Comment #3 from Hin-Chung Lam <hclam at google.com>  2012-08-09 15:56:10 PST ---
(From update of attachment 157418)
View in context: https://bugs.webkit.org/attachment.cgi?id=157418&action=review

> Source/WebCore/platform/graphics/RetainedModeBitmapImage.cpp:1
> +/*

I think a better name would be NonImmediateBitmapImage. It is unclear from the name what RetainedModeBitmapImage does.

> Source/WebCore/platform/graphics/RetainedModeBitmapImage.cpp:40
> +    , m_retainedModeCount(0)

This can be a simple boolean instead of counter.

> Source/WebCore/platform/graphics/RetainedModeBitmapImage.cpp:46
> +    RetainedModeSaver retainedModeSaver(this);

There's no need to have this because this method doesn't trigger image decoding.

> Source/WebCore/platform/graphics/RetainedModeBitmapImage.cpp:106
> +    RetainedModeSaver retainedModeSaver(this);

It will be more clear to only have this line in this method and draw().

> Source/WebCore/platform/graphics/RetainedModeBitmapImage.cpp:148
> +RetainedModeBitmapImage* toRetainedModeBitmapImage(Image* image)

Looks like there's no user of this function other than toRetainedModeBitmapImageIfPossible, I'd combine them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.