[Webkit-unassigned] [Bug 93644] [BlackBerry] Introduce a JavaScript Variant object

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93644


Adam Treat <atreat at rim.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #157529|review?                     |review-
               Flag|                            |




--- Comment #4 from Adam Treat <atreat at rim.com>  2012-08-09 14:04:01 PST ---
(From update of attachment 157529)
View in context: https://bugs.webkit.org/attachment.cgi?id=157529&action=review

I think this looks good overall.  Please fix the issues and then I'll look one last time.

> Source/WebKit/blackberry/Api/JavaScriptVariant.cpp:87
> +        // Output warning?

ASSERT_NOT_REACHED() I would say.

> Source/WebKit/blackberry/Api/JavaScriptVariant.h:29
> +

Remove the extra new line here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.