[Webkit-unassigned] [Bug 93492] [Qt] Make it possible to build without QtTest/QtPrintSuport

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93492





--- Comment #3 from Loïc Yhuel <loic.yhuel at softathome.com>  2012-08-09 11:26:20 PST ---
(In reply to comment #2)
> (From update of attachment 157241 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=157241&action=review
> 
> > Tools/QtTestBrowser/launcherwindow.cpp:727
> > +#if !defined(QT_NO_PRINTER) && defined(HAVE_QTPRINTSUPPORT) && HAVE_QTPRINTSUPPORT
> 
> Why not just HAVE(QPRINTSUPPORT)?
It was a copy-paste of what I did in launcherwindow.h, where HAVE() macro is not defined. But in fact, the code in the header can be moved to the cpp.
> 
> > Tools/Tools.pro:12
> > +    contains(DEFINES, HAVE_QTTESTLIB=1): SUBDIRS += DumpRenderTree/qt/DumpRenderTree.pro
> 
> I'd like some sort of warning here, like in default_pre, that we're disabling DRT due to missing testlib.
Only for DRT, or WTR and tests too ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.