[Webkit-unassigned] [Bug 90267] Handle SSL errors for SOUP

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90267


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #152205|review?                     |review+
               Flag|                            |




--- Comment #37 from Martin Robinson <mrobinson at webkit.org>  2012-08-09 09:55:07 PST ---
(From update of attachment 152205)
View in context: https://bugs.webkit.org/attachment.cgi?id=152205&action=review

> Source/WebCore/ChangeLog:18
> +        (WebCore::ResourceError::ResourceError): Add new constrcutor for

constrcutor -> constructor

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:164
> +class HostTLSCertificates {

Maybe HostTLSCertificateSet to to make it clear that this is a set?

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:166
> +    static const size_t sha1HashSize = 20;

This can be defined in the scope that it's used.

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:175
> +    bool check(GTlsCertificate* certificate)

How about "contains" ?

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:195
> +        return base64Encode(reinterpret_cast<const char*>(digest.data()), sha1HashSize);

It's a bit surprising that base64Encode does not return a CString.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.