[Webkit-unassigned] [Bug 74864] There is additional space not belonged to a table between the table cells

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74864





--- Comment #22 from Arpita Bahuguna <arpitabahuguna at gmail.com>  2012-08-09 05:28:31 PST ---
(In reply to comment #19)
> (From update of attachment 156934 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=156934&action=review
> 
> Allan was right, sorry for being unclear.
> 
Ah! I completely misunderstood. Have made the necessary changes now. Shall also take care of this in the future.

> > Source/WebCore/rendering/RenderTableSection.cpp:1121
> > +    // The use of upper_bound algorithm makes the behavior of hittest (on table-cell edges) in accordance
> > +    // with other browsers.
> 
> I think you should substantiate on the 'why' we match other browsers (it's good to show that you tested it and found us in compliance but it's a bit dry). How is upper_bound better than lower_bound here? This would be a high value comment for anyone reading this code.
> 
Have tried to add an explanatory comment as to why upper_bound is preferred over lower_bound.

> > Source/WebCore/rendering/RenderTableSection.cpp:1122
> > +    // https://bugs.webkit.org/show_bug.cgi?id=74864
> 
> I don't think adding the bug number adds any information to the change. My rule of thumb for including a bug number is either to track an existing failure or because the bug has a discussion that adds a lot to the understanding of how the code is structured or why it behaves this way.
> 
Understand. Have removed the same.

> > LayoutTests/fast/dom/hittest-tablecell-bottom-edge.html:24
> > +    x = ele.getBoundingClientRect().right/2;
> 
> Nit: middleX may be more readable in the output. (not repeated for the other tests)
Made the required changes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.