[Webkit-unassigned] [Bug 93467] Change ImageSource to be asynchronous.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 9 00:37:41 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=93467





--- Comment #5 from Huang Dongsung <luxtella at company100.net>  2012-08-09 00:38:06 PST ---
(In reply to comment #4)
> Created an attachment (id=157406)
 --> (https://bugs.webkit.org/attachment.cgi?id=157406&action=review) [details]
> Patch

This patch introduced SynchronousImageSource, which Alpha suggested.
SynchronousImageSource makes us avoid making a mistake.

So, the changelog was also changed.
"This change makes the API of ImageSource support asynchronous image decoding. This
is a preparation for asynchronous image decoding. After ImageSource
completes image decoding, ImageSource sends NativeImagePtr to BitmapImage via
ImageSourceObserver::didDecodeFrameAtIndex().

This patch renames createFrameAtIndex to requestFrameAtIndex, to imply
this method can be asynchronous.

This patch introduced SynchronousImageSource, which decodes image synchronously.
The main reason to add this class is to prevent clients from misusing
ImageSource. ImageSource will be able to perform sync and async image decoding,
so it will be hard to use ImageSource correctly. So, after this patch, only
BitmapImage and SynchronousImageSource can create and use ImageSource, and other
clients which need to use ImageSource must use SynchronousImageSource.
Currently, GraphicsContext3D and WebImageSkia use SynchronousImageSource."

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list