[Webkit-unassigned] [Bug 93523] Why doesn't RotateTransformOperation::blend() check for |this| being axis-aligned too?

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93523





--- Comment #1 from Dirk Schulze <krit at webkit.org>  2012-08-08 18:52:51 PST ---
Created an attachment (id=157366)
 --> (https://bugs.webkit.org/attachment.cgi?id=157366&action=review)
Shows error on Chrome

I wrote a simple test case. It is indeed a bug not to check the resulting rotation as well. Actually it does not affect Safari, since it seems to use the logic of CoreAnimation. But you can see the problem in Chrome. The element just gets rotated by the y-axis of the initial transform and does not animate around the x-axis as well. It jumps to the correct result after the animation.

I wonder why we just optimize for vectors of the length of 1? If the vectors go in the same direction, the length doesn't matter. So it should be more like:

((fromOp->m_x == m_x) == 0 &&
(fromOp->m_y == m_y) == 0 &&
(fromOp->m_z == m_z) > 0)

for the z-axis and similar for every axis. It should also be possible to use the fast track if both vectors are negative.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.