[Webkit-unassigned] [Bug 93275] Windows 64 bit compliance

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 8 13:37:29 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=93275





--- Comment #9 from Brent Fulgham <bfulgham at webkit.org>  2012-08-08 13:37:52 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> 
> > This is a good start, but needs a few adjustments before landing.  I think Patrick's idea to use the WindowsExtras.h code is good, but I think you will need to add a static value to represent the token you want to get from GetWindowLongPtr.
> 
> Try adding #include "WindowsExtras.h" to WinLauncher.cpp.  It doesn't know what to do with the #if OS(WINCE) directive.

Ah, right.  That's internal to WebCore.

Why not do an #if/def around it using the _M_AMD64 and _WIN64.  WINCE won't define these, and can stick to the old way.

Then you don't need to touch WindowsExtras at all, and it should build fine on all systems.

-Brent

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list