[Webkit-unassigned] [Bug 93400] Improve RenderObject.h compile time - split CachedImage and CachedImageClient

Wed Aug 8 11:35:11 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=93400

Dean Jackson <dino at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dino at apple.com

--- Comment #17 from Dean Jackson <dino at apple.com>  2012-08-08 11:35:33 PST ---
This broke the Mac builds.

CompileC "/Volumes/Data/slave/lion-production-archive/build/build-Production/WebCore.roots/WebCore~obj/WebCore.build/WebCore.build/Objects-normal/i386/ClipboardMac.o" platform/mac/ClipboardMac.mm normal i386 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler
    cd /Volumes/Data/slave/lion-production-archive/build/build-Production/WebCore.roots/WebCore
    setenv LANG en_US.US-ASCII
    /usr/bin/clang -x objective-c++ -arch i386 -fmessage-length=0 -fdiagnostics-print-source-range-info -fdiagnostics-show-category=id -fdiagnostics-parseable-fixits -stdlib=libc++ -fobjc-gc -Wno-trigraphs -fno-exceptions -fno-rtti -fpascal-strings -O2 -Werror -Wmissing-prototypes -Wno-return-type -Wnon-virtual-dtor -Wparentheses -Wswitch -Wno-unused-parameter -Wno-unused-variable -Wunused-value -Wsign-compare -Wno-shorten-64-to-32 -Wnewline-eof -Wno-arc-abi -Wno-c++0x-extensions -DNDEBUG -DENABLE_3D_RENDERING -DENABLE_BLOB -DENABLE_CHANNEL_MESSAGING -DENABLE_CSS_BOX_DECORATION_BREAK -DENABLE_CSS_EXCLUSIONS -DENABLE_CSS_FILTERS -DENABLE_CSS_REGIONS -DENABLE_CSS_SHADERS -DENABLE_CSS_STICKY_POSITION -DENABLE_CSS3_FLEXBOX -DENABLE_DASHBOARD_SUPPORT -DENABLE_DETAILS_ELEMENT -DENABLE_FILTERS -DENABLE_FULLSCREEN_API -DENABLE_GEOLOCATION -DENABLE_HIGH_DPI_CANVAS -DENABLE_ICONDATABASE -DENABLE_IFRAME_SEAMLESS -DENABLE_JAVASCRIPT_DEBUGGER -DENABLE_LEGACY_CSS_VENDOR_PREFIXES -DENABLE_MATHML -D
In file included from /Volumes/Data/slave/lion-production-archive/build/build-Production/WebCore.roots/WebCore/platform/mac/ClipboardMac.mm:27:
/Volumes/Data/slave/lion-production-archive/build/build-Production/WebCore.roots/WebCore/platform/mac/ClipboardMac.h:40:47:{40:40-40:64}: error: base class has incomplete type [2]
 class ClipboardMac : public Clipboard, public CachedImageClient {
                                        ~~~~~~~^~~~~~~~~~~~~~~~~
/Volumes/Data/slave/lion-production-archive/build/build-Production/WebCore.roots/WebCore/svg/graphics/SVGImageCache.h:34:7: note: forward declaration of 'WebCore::CachedImageClient'
 class CachedImageClient;
       ^
/Volumes/Data/slave/lion-production-archive/build/build-Production/WebCore.roots/WebCore/platform/mac/ClipboardMac.mm:345:39:{345:39-345:43}: error: cannot initialize a parameter of type 'WebCore::CachedResourceClient *' with an rvalue of type 'WebCore::ClipboardMac *' [2]
             m_dragImage->removeClient(this);
                                       ^~~~
/Volumes/Data/slave/lion-production-archive/build/build-Production/WebCore.roots/WebCore/loader/cache/CachedResource.h:117:44: note: passing argument to parameter here [2]
     void removeClient(CachedResourceClient*);
                                            ^
/Volumes/Data/slave/lion-production-archive/build/build-Production/WebCore.roots/WebCore/platform/mac/ClipboardMac.mm:348:36:{348:36-348:40}: error: cannot initialize a parameter of type 'WebCore::CachedResourceClient *' with an rvalue of type 'WebCore::ClipboardMac *' [2]
             m_dragImage->addClient(this);
                                    ^~~~
/Volumes/Data/slave/lion-production-archive/build/build-Production/WebCore.roots/WebCore/loader/cache/CachedResource.h:116:41: note: passing argument to parameter here [2]
     void addClient(CachedResourceClient*);
                                         ^
In file included from /Volumes/Data/slave/lion-production-archive/build/build-Production/SafariRoot/usr/local/include/wtf/RefPtr.h:28:
In file included from /Volumes/Data/slave/lion-production-archive/build/build-Production/SafariRoot/usr/local/include/wtf/VectorTraits.h:25:
In file included from /Volumes/Data/slave/lion-production-archive/build/build-Production/SafariRoot/usr/local/include/wtf/Vector.h:30:
In file included from /Volumes/Data/slave/lion-production-archive/build/build-Production/SafariRoot/usr/local/include/wtf/text/StringImpl.h:31:
In file included from /Volumes/Data/slave/lion-production-archive/build/build-Production/SafariRoot/usr/local/include/wtf/text/WTFString.h:29:
In file included from /Volumes/Data/slave/lion-production-archive/build/build-Production/WebCore.roots/WebCore/platform/text/PlatformString.h:28:
In file included from /Volumes/Data/slave/lion-production-archive/build/build-Production/WebCore.roots/WebCore/loader/cache/CachedResource.h:28:
In file included from /Volumes/Data/slave/lion-production-archive/build/build-Production/WebCore.roots/WebCore/loader/cache/CachedImage.h:26:
In file included from /Volumes/Data/slave/lion-production-archive/build/build-Production/WebCore.roots/WebCore/platform/mac/ClipboardMac.h:29:
In file included from /Volumes/Data/slave/lion-production-archive/build/build-Production/WebCore.roots/WebCore/platform/mac/ClipboardMac.mm:27:
/Volumes/Data/slave/lion-production-archive/build/build-Production/SafariRoot/usr/local/include/wtf/PassRefPtr.h:65:67:{65:73-65:84}: error: cannot initialize a member subobject of type 'WebCore::Clipboard *' with an rvalue of type 'WebCore::ClipboardMac *' [2]
         template<typename U> PassRefPtr(const PassRefPtr<U>& o) : m_ptr(o.leakRef()) { }
                                                                   ^     ~~~~~~~~~~~
/Volumes/Data/slave/lion-production-archive/build/build-Production/WebCore.roots/WebCore/platform/mac/ClipboardMac.mm:52:12: note: in instantiation of function template specialization 'WTF::PassRefPtr<WebCore::Clipboard>::PassRefPtr<WebCore::ClipboardMac>' requested here [2]
     return ClipboardMac::create(DragAndDrop, dragData->pasteboardName(), policy, dragData->containsFiles() ? ClipboardMac::DragAndDropFiles : ClipboardMac::DragAndDropData, frame);
            ^
4 errors generated.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.