[Webkit-unassigned] [Bug 93275] Windows 64 bit compliance

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 8 11:14:33 PDT 2012


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #156716|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |

--- Comment #7 from Brent Fulgham <bfulgham at webkit.org>  2012-08-08 11:14:56 PST ---
(From update of attachment 156716)
View in context: https://bugs.webkit.org/attachment.cgi?id=156716&action=review

This is a good start, but needs a few adjustments before landing.  I think Patrick's idea to use the WindowsExtras.h code is good, but I think you will need to add a static value to represent the token you want to get from GetWindowLongPtr.

>> Tools/WinLauncher/WinLauncher.cpp:232
>> +    ::SetWindowLongPtr(hMainWnd, GWLP_WNDPROC, reinterpret_cast<LONG_PTR>(WndProc));
> i'd like to see usage of http://trac.webkit.org/browser/trunk/Source/WebCore/platform/win/WindowsExtras.h instead, which adds additional abstraction required for OS(WINCE).

How would using that help with GWL_WNDPROC versus GWLP_WNDPROC?  GWL_WNDPROC resolves to -4 for win32 (and to nothing in 64-bit), while GWLP_WNDPROC is -4 for 64-bit, and undefined for 32-bit.

I guess we could add a static const "s_wndProc" member to the WindowsExtras.h that would be defined as -4.

>> Tools/win/DLLLauncher/DLLLauncherMain.cpp:198
>> +#endif
> they look very similar

Maybe this should be "#ifdef _M_AMD64 || _WIN64"?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list