[Webkit-unassigned] [Bug 92737] Enable kerning on Android

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 8 10:29:26 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=92737





--- Comment #3 from Peter Beverloo <peter at chromium.org>  2012-08-08 10:29:50 PST ---
(From update of attachment 157245)
View in context: https://bugs.webkit.org/attachment.cgi?id=157245&action=review

Looks good to me, although I'd like a clarification in the ChangeLog re: testing.

> Source/WebCore/ChangeLog:12
> +        Testing: existing UI tests (not all unforked yet)

Kerning is something that also comes up in layout tests, will this influence our results there?

> Source/WebCore/platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:-83
> -#if OS(ANDROID)

Nit: since this change is specific to Chromium and doesn't touch other platforms, you could prefix the bug's subject with [Chromium].

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list