[Webkit-unassigned] [Bug 89742] [Win] key event's location does not work on Windows platform.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89742





--- Comment #3 from Alexey Proskuryakov <ap at webkit.org>  2012-08-08 09:44:09 PST ---
(From update of attachment 149232)
View in context: https://bugs.webkit.org/attachment.cgi?id=149232&action=review

r- mostly due to Ryosuke's comments - it's clear that a new patch and another round of review will be needed.

> Source/WebKit/chromium/ChangeLog:14
> +        * src/win/WebInputEventFactory.cpp:
> +        (WebKit::windowsKeycodeWithLocation):

This code seems port neutral. Why does it have to be in chromium directory? What do other ports do?

> Source/WebKit/chromium/src/win/WebInputEventFactory.cpp:123
> +    // WindowsVista or new Windows can support 0xe0 or 0xe1 to specify
> +    // the extended scancode. In this case, if extended key bit is set,
> +    // extended scancode is 0xe000 | scancode or 0xe100 | scancode.
> +    int virtualKeycode = ::MapVirtualKey(scancode, MAPVK_VSC_TO_VK_EX);

I have a lot of difficulty understanding this comment, and how it relates to the code below.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.