[Webkit-unassigned] [Bug 93278] QtWebKit fails to build with OpenGL support on QNX

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93278


Noam Rosenthal <noam.rosenthal at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #157199|review?                     |review-
               Flag|                            |




--- Comment #3 from Noam Rosenthal <noam.rosenthal at nokia.com>  2012-08-08 08:08:46 PST ---
(From update of attachment 157199)
View in context: https://bugs.webkit.org/attachment.cgi?id=157199&action=review

Seems like a hacky way of doing this. We already disable 3D_GRAPHICS on windows, see code above in the same file.

> Tools/qmake/mkspecs/features/features.prf:258
> +    DEFINES -= ENABLE_3D_RENDERING=1
> +    DEFINES += ENABLE_3D_RENDERING=0

You don't need to disable this, it doesn't need 3D graphics.

> Tools/qmake/mkspecs/features/features.prf:260
> +    DEFINES -= ENABLE_WEBGL=1
> +    DEFINES += ENABLE_WEBGL=0

Not needed. This will be disabled by default if 3D_GRAPHICS is disabled.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.