[Webkit-unassigned] [Bug 91832] [EFL][WK2] Implemented color chooser proxy and input picker interface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91832





--- Comment #23 from Ryuan Choi <ryuan.choi at samsung.com>  2012-08-08 07:50:08 PST ---
(From update of attachment 154833)
View in context: https://bugs.webkit.org/attachment.cgi?id=154833&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1105
> +    EINA_SAFETY_ON_NULL_RETURN(smartData->api->input_picker_show);

EINA_SAFETY_ON_NULL_RETURN will complain when input_picker_show is null.

please change this as `if () return;`

> Source/WebKit2/UIProcess/efl/WebColorChooserProxyEfl.cpp:43
> +WebColorChooserProxyEfl::~WebColorChooserProxyEfl()
> +{
> +}

I am not sure whether we don't need to clear colorChooser of ewk_view.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.