[Webkit-unassigned] [Bug 93458] [Texmap] Render gif animation well.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93458


Noam Rosenthal <noam.rosenthal at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #157169|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #4 from Noam Rosenthal <noam.rosenthal at nokia.com>  2012-08-08 06:35:08 PST ---
(From update of attachment 157169)
View in context: https://bugs.webkit.org/attachment.cgi?id=157169&action=review

Good catch, see comments.

> Source/WebCore/ChangeLog:12
> +        No new tests, hard to write a test case.

Even harder to catch regressions later on... Please find the right test case for this, e.g. changing the frame and then testing for pixels.

> Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:329
> +    NativeImagePtr newNativeImagePtr = image->nativeImageForCurrentFrame();

You need a null check.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.