[Webkit-unassigned] [Bug 91630] Web Inspector: Incorrect XHR responses when two async xhrs are sent synchronously

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91630


Vsevolod Vlasov <vsevik at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #156938|review?                     |review-
               Flag|                            |




--- Comment #22 from Vsevolod Vlasov <vsevik at chromium.org>  2012-08-07 23:02:15 PST ---
(From update of attachment 156938)
View in context: https://bugs.webkit.org/attachment.cgi?id=156938&action=review

Please fix the tests.

> Source/WebCore/inspector/InspectorInstrumentation.h:175
> +    static void didReceiveResourceResponse(const InspectorInstrumentationCookie&, unsigned long identifier, DocumentLoader*, const ResourceResponse&, ResourceLoader* = 0);

nit: I don't think we should have default argument values for this method.

> Source/WebCore/loader/ResourceLoadNotifier.cpp:126
> +void ResourceLoadNotifier::dispatchDidReceiveResponse(DocumentLoader* loader, unsigned long identifier, const ResourceResponse& r, ResourceLoader *resourceLoader)

ResourceLoader* resourceLoader

> LayoutTests/http/tests/inspector/network-test.js:30
> +    doXHRWithPayload(method, url, async, payload, null);

callback is missing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.