[Webkit-unassigned] [Bug 92996] [CSS Regions] region-overflow: break still renders the content that does not fit in the last region.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92996


Julien Chaffraix <jchaffraix at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #156526|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #3 from Julien Chaffraix <jchaffraix at webkit.org>  2012-08-06 15:07:24 PST ---
(From update of attachment 156526)
View in context: https://bugs.webkit.org/attachment.cgi?id=156526&action=review

The change looks fine.

By the way - probably related - but shouldn't RenderBlock::hasNextPage be changed too? AFAICT we shouldn't have an extra page after the last region if it has region-overflow: break but the code seems to imply that we do.

> LayoutTests/fast/regions/region-overflow-break-expected.html:15
> +#gray {
>      overflow:visible;
>  }

This doesn't look fine but I guess it is expected because we don't implement forced region breaking. I would put a FIXME as it's confusing if you don't know our current implementation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.