[Webkit-unassigned] [Bug 93275] Windows 64 bit compliance

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93275





--- Comment #4 from Patrick R. Gansterer <paroga at paroga.com>  2012-08-06 14:54:14 PST ---
(From update of attachment 156716)
View in context: https://bugs.webkit.org/attachment.cgi?id=156716&action=review

> Tools/WinLauncher/WinLauncher.cpp:232
> -    DefWebKitProc = reinterpret_cast<WNDPROC>(::GetWindowLongPtr(hMainWnd, GWL_WNDPROC));
> -    ::SetWindowLongPtr(hMainWnd, GWL_WNDPROC, reinterpret_cast<LONG_PTR>(WndProc));
> +    DefWebKitProc = reinterpret_cast<WNDPROC>(::GetWindowLongPtr(hMainWnd, GWLP_WNDPROC));
> +    ::SetWindowLongPtr(hMainWnd, GWLP_WNDPROC, reinterpret_cast<LONG_PTR>(WndProc));

i'd like to see usage of http://trac.webkit.org/browser/trunk/Source/WebCore/platform/win/WindowsExtras.h instead, which adds additional abstraction required for OS(WINCE).

> Tools/win/DLLLauncher/DLLLauncherMain.cpp:191
> +#ifdef _M_AMD64
> +    const char* entryPointName = "_dllLauncherEntryPoint";
> +#else
>      const char* entryPointName = "_dllLauncherEntryPoint at 8";
> +#endif

isn't there a possibility to export them as extern C without any additional decoration?

> Tools/win/DLLLauncher/DLLLauncherMain.cpp:198
> +#ifdef _M_AMD64
>      const char* entryPointName = "_dllLauncherEntryPoint at 16";
> +#else
> +    const char* entryPointName = "_dllLauncherEntryPoint at 16";
> +#endif

they look very similar

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.