[Webkit-unassigned] [Bug 93090] Web Inspector: requests filtering in network tab

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93090


Vsevolod Vlasov <vsevik at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #156696|review?                     |review-
               Flag|                            |




--- Comment #10 from Vsevolod Vlasov <vsevik at chromium.org>  2012-08-06 08:52:40 PST ---
(From update of attachment 156696)
View in context: https://bugs.webkit.org/attachment.cgi?id=156696&action=review

> Source/WebCore/ChangeLog:11
> +        No new tests (OOPS!).

Please remove this line (and 1 blank line).

> Source/WebCore/inspector/front-end/FilterController.js:50
> +    cancelFilter: function() {

Here and everywhere: we put open bracket { to the next line after the function name.

> Source/WebCore/inspector/front-end/FilterController.js:60
> +    _performFilter: function(query) {

Please add compiler annotations to this function.

> Source/WebCore/inspector/front-end/NetworkPanel.js:443
> +        for(var i = 0; i < this._dataGrid.rootNode().children.length; ++i){

Please add space after for and a space before bracket.

> Source/WebCore/inspector/front-end/NetworkPanel.js:447
> +            if (node.element.children[0].innerText.indexOf(content) === -1){

Please use createPlainTextSearchRegex like it is done in performSearch.
Also a space before bracket please.

> Source/WebCore/inspector/front-end/NetworkPanel.js:1175
> +    performFilter: function(query) {

Please add compiler annotations to this function.

> Source/WebCore/inspector/front-end/NetworkPanel.js:1442
> +    performFilter: function(query){

Please add compiler annotations to this function.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.