[Webkit-unassigned] [Bug 93090] Web Inspector: requests filtering in network tab

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93090


Vsevolod Vlasov <vsevik at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #156685|review?                     |review-
               Flag|                            |




--- Comment #8 from Vsevolod Vlasov <vsevik at chromium.org>  2012-08-06 07:33:47 PST ---
(From update of attachment 156685)
View in context: https://bugs.webkit.org/attachment.cgi?id=156685&action=review

> Source/WebCore/ChangeLog:3
> +        A new feature added: filtering in the network panel.

This line should be equal to the bug summary.

> Source/WebCore/ChangeLog:5
> +        Reviewed by NOBODY (OOPS!).

Please add a blank line before this line.

> Source/WebCore/ChangeLog:6
> +

Please add a change description here. See previous changes's ChangeLogs for the reference

> Source/WebCore/inspector/front-end/FilterController.js:5
> + * modification, are permitted provided that the following conditions are met: *

Please fix formatting of the license text, there should be new lines before '*'. It should look the same as in the other files.

> Source/WebCore/inspector/front-end/FilterController.js:33
> +    this._element.cellSpacing = 0;

Please remove this.

> Source/WebCore/inspector/front-end/FilterController.js:35
> +    // Column 1

Please remove these comments.

> Source/WebCore/inspector/front-end/NetworkPanel.js:-754
> -

Please revert this change.

> Source/WebCore/inspector/front-end/NetworkPanel.js:1757
> +        if (!this._parentView._hiddenCategories.all && !this._parentView._filteredOutRequests.get(this._request))

It is enough to look at _filteredOutRequests once.

if (this._parentView._filteredOutRequests.get(this._request))
    return true;
if (!this._parentView._hiddenCategories.all)
    return false;
return this._request.type.name() in this._parentView._hiddenCategories;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.