[Webkit-unassigned] [Bug 92739] Web Inspector: Protocol: Add "namedFlowCreated" and "namedFlowRemoved" events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92739


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #156323|review?                     |review-
               Flag|                            |




--- Comment #8 from Pavel Feldman <pfeldman at chromium.org>  2012-08-06 06:34:38 PST ---
(From update of attachment 156323)
View in context: https://bugs.webkit.org/attachment.cgi?id=156323&action=review

Looks good, once issue below...

> Source/WebCore/inspector/InspectorCSSAgent.cpp:540
> +    m_frontend->namedFlowCreated(m_domAgent->pushNodePathToFrontend(document), name.string());

Sorry for not spotting this earlier. By design, protocol should not emit any events unless they are explicitly requested by the client. In your case, attaching to the backend will start populating DOM with nodes and issuing these events. So we need to figure out how to prevent that from happening. What we try to do in such cases is:
- events are not generated unless getNamedFlowCollection is called for given document node
- once getNamedFlowCollection was called at least once, namedFromCreated/Deleted events start flowing to the front-end

That will make behaviour consistent: once you asked for the present state, you get update notifications, you would not need to call pushNodePathToFrontend anymore - boundNodeId would be sufficient.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.