[Webkit-unassigned] [Bug 93262] [WK2][GTK] Improvements for the new spell-checking API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93262


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #156680|review?                     |review+
               Flag|                            |




--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-08-06 06:33:49 PST ---
(From update of attachment 156680)
View in context: https://bugs.webkit.org/attachment.cgi?id=156680&action=review

Please, check the comments I made here before landing, thanks!

> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:485
> +    if (!spellCheckingLanguages.length())

Use spellCheckingLanguages.isNull() instead.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:517
> +    context->priv->textChecker->setSpellCheckingLanguages(CString(languages));

A char* can be assigned to a CString, so I'm not sure, but I think you can pass the languages directly here:

context->priv->textChecker->setSpellCheckingLanguages(languages);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.