[Webkit-unassigned] [Bug 93257] Web Inspector: a tiny refactoring of Highlighter in InspectorDOMAgent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93257


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #156662|review?                     |review+
               Flag|                            |




--- Comment #3 from Pavel Feldman <pfeldman at chromium.org>  2012-08-06 05:08:35 PST ---
(From update of attachment 156662)
View in context: https://bugs.webkit.org/attachment.cgi?id=156662&action=review

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1008
> +        m_inspectModeHighlightConfig = highlightConfigFromInspectorObject(errorString, highlightInspectorObject);

You should return early in case of error.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1054
> +        if (highlightConfig)

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.