[Webkit-unassigned] [Bug 93258] [Qt][WK2] Fix the --minimal build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93258


Andras Becsi <abecsi at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abecsi at webkit.org




--- Comment #1 from Andras Becsi <abecsi at webkit.org>  2012-08-06 04:58:23 PST ---
(In reply to comment #0)
> Now the --minimal build is broken with Qt 5 with the following errors:
> /home/oszi/WebKit/Source/WebKit2/PluginProcess/PluginProcess.cpp: In member function 'void WebKit::PluginProcess::initialize(int, WebCore::RunLoop*)':
> /home/oszi/WebKit/Source/WebKit2/PluginProcess/PluginProcess.cpp:95: error: 'NetscapePlugin' has not been declared
> ...
> /home/oszi/WebKit/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp:88: error: 'releaseNPObject' was not declared in this scope
> /home/oszi/WebKit/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp:91: error: 'releaseNPObject' was not declared in this scope
> ...
> /home/oszi/WebKit/Source/WebKit2/PluginProcess/qt/PluginProcessMainQt.cpp:59: error: ‘QLibrary’ was not declared in this scope

These look like a guard is missing somewhere. Is the revision which broke the build known?

> 
> Do we want to support --minial build for Qt 5 WK2? 
> Or should we do --minimal --no-webkit2 build on the minimal bot? (It works fine.)

I personally think the minimal build is still valuable for testing at least one set of feature guards and as far as I remember the maintenance cost is not that high since the breakages were considerable rare.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.