[Webkit-unassigned] [Bug 92342] Web Inspector [JSC]: Support multi instance for PageScriptDebugServer of JSC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92342





--- Comment #29 from Peter Wang <peter.wang at torchmobile.com.cn>  2012-08-06 04:53:49 PST ---
(In reply to comment #28)
> (From update of attachment 155267 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=155267&action=review
> 
> > Source/WebCore/bindings/js/PageScriptDebugServer.cpp:105
> >  void PageScriptDebugServer::removeListener(ScriptDebugListener* listener, Page* page)
> 
> We can make v8's implementation also keep a pointer to the Page and remove the second argument from the method. Can be done in another patch.
ok. 
> > Source/WebCore/bindings/js/PageScriptDebugServer.cpp:143
> > +    if (page && page == m_page)
> 
> I don't think we need page == m_page check as PageScriptDebugServer listens to only one page.
> 
> > Source/WebCore/bindings/js/PageScriptDebugServer.cpp:152
> > +    if (page && page == m_page)
> 
> ok.
> 
> > Source/WebCore/bindings/js/PageScriptDebugServer.h:52
> > +    static PageDebugServerMap& pageServerMap();
> 
> This one should be private.
> 
> > Source/WebCore/inspector/InspectorProfilerAgent.cpp:107
> > +        ScriptDebugServer* server = new WorkerScriptDebugServer(m_workerContext);
> 
> It will create WorkerScriptDebugServer that is never deleted.
It's here just for pass compiling. In my new patch I removed  "scriptDebugServer()" from "InspectorProfilerAgent", so we don't need it anymore.

> > Source/WebCore/inspector/InspectorProfilerAgent.cpp:235
> > +    scriptDebugServer().recompileAllJSFunctionsSoon();
> 
> Can we avoid creating ScriptDebugServer just to recompile js functions?
Thx. It's a great idea. I will have a try.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.