[Webkit-unassigned] [Bug 93253] Web Inspector: renaming DOMNodeHighlighter to InspectorOverlay

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 6 04:34:58 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=93253


Andrey Kosyakov <caseq at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #156651|review?                     |
               Flag|                            |




--- Comment #2 from Andrey Kosyakov <caseq at chromium.org>  2012-08-06 04:34:55 PST ---
(From update of attachment 156651)
View in context: https://bugs.webkit.org/attachment.cgi?id=156651&action=review

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1008
> +    if (enabled)
> +        m_inspectModeHighlightConfig = highlightConfigFromInspectorObject(errorString, highlightInspectorObject);

please split this into a separate change.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1019
> +        return PassOwnPtr<HighlightConfig> ();

return nullptr?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list